Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap the ref parse #935

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: swap the ref parse #935

merged 1 commit into from
Nov 28, 2024

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Nov 28, 2024

✨ Context

As @DSuveges found, there was an issue with how make build works. The condition to get the REF was swapped in Makefile, this PR attempts to fix it.

Tested on this branch and tag test and this branch build the artifacts with correct namespaces

 gentropy [szsz-fix-make-build] make build
Updated property [core/project].
Packaging Code and Dependencies for gentropy-0.0.0
Building gentropy (0.0.0)
  - Building sdist
  - Built gentropy-0.0.0.tar.gz
  - Building wheel
  - Built gentropy-0.0.0-py3-none-any.whl
Uploading to gs://genetics_etl_python_playground/initialisation/gentropy/szsz-fix-make-build
Copying file://src/gentropy/cli.py [Content-Type=text/x-python]...
/ [1 files][  546.0 B/  546.0 B]
Operation completed over 1 objects/546.0 B.
Copying file://./dist/gentropy-0.0.0-py3-none-any.whl [Content-Type=application/octet-stream]...
/ [1 files][264.4 KiB/264.4 KiB]
Operation completed over 1 objects/264.4 KiB.
Copying file://./utils/install_dependencies_on_cluster.sh [Content-Type=application/x-sh]...
/ [1 files][  1.8 KiB/  1.8 KiB]
Operation completed over 1 objects/1.8 KiB.
☁  gentropy [szsz-fix-make-build] git checkout test
Note: switching to 'test'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at e92fb336 fix: swap the ref parse
☁  gentropy [test] make build
Updated property [core/project].
Packaging Code and Dependencies for gentropy-0.0.0
Building gentropy (0.0.0)
  - Building sdist
  - Built gentropy-0.0.0.tar.gz
  - Building wheel
  - Built gentropy-0.0.0-py3-none-any.whl
Uploading to gs://genetics_etl_python_playground/initialisation/gentropy/test
Copying file://src/gentropy/cli.py [Content-Type=text/x-python]...
/ [1 files][  546.0 B/  546.0 B]
Operation completed over 1 objects/546.0 B.
Copying file://./dist/gentropy-0.0.0-py3-none-any.whl [Content-Type=application/octet-stream]...
/ [1 files][264.4 KiB/264.4 KiB]
Operation completed over 1 objects/264.4 KiB.
Copying file://./utils/install_dependencies_on_cluster.sh [Content-Type=application/x-sh]...
/ [1 files][  1.8 KiB/  1.8 KiB]
Operation completed over 1 objects/1.8 KiB.

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working size-XS labels Nov 28, 2024
@project-defiant project-defiant marked this pull request as ready for review November 28, 2024 11:44
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repository reference is picked depending on a condition:

  1. If the tag is checked out, the tag (ie. v2.0.0rc2) is used as reference for built package location.
  2. If we are not on the checked out tag, the current branch is used (eg. dev).

All makes sense, thanks!

@DSuveges DSuveges merged commit ff35db4 into dev Nov 28, 2024
7 checks passed
@DSuveges DSuveges deleted the szsz-fix-make-build branch November 28, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size-XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants