-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: define dependency version constraints + other fixes #945
Conversation
Bumps [wandb](https://github.com/wandb/wandb) from 0.18.5 to 0.19.0. - [Release notes](https://github.com/wandb/wandb/releases) - [Changelog](https://github.com/wandb/wandb/blob/main/CHANGELOG.md) - [Commits](wandb/wandb@v0.18.5...v0.19.0) --- updated-dependencies: - dependency-name: wandb dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…targets/gentropy into il-fix-scikit-conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To sum this PR:
- fix on the upper bound of the package versions (this makes the
caret
operator redundant in all cases (https://python-poetry.org/docs/dependency-specification/#caret-requirements) - Test to check if all modules are importable.
Note: We could fix the versions in more famiialar way (>=X, <Y)
(a bit simpler to understand then the caret operator.
pyproject.toml
Outdated
pydoclint = ">=0.3.8,<0.6.0" | ||
prettier = "^0.0.7" | ||
prettier = "^0.0.7, <0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier version would never reach 0.0.8
and above
@SzymonSzyszkowski I changed the caret so that it is more explicit.Thank you ^^ |
@ireneisdoomed well done! |
✨ Context
A recent update to the
scikit-learn
package has caused the L2G step in Gentropy to fail due to an incompatibility betweenscikit-learn
and another dependency,skops
.Specifically:
scikit-learn
has been updated to version1.6.0
, which is incompatible withskops==0.10.0
.because skops does not pin the version of scikit-learn, dependency resolution results in incompatible package versions when a user installs the Gentropy wheel now:
🛠 What does this PR implement
In this PR, we define upper limits to the version constraints of all dependencies. This way that we avoid resolving to versions including minor updates that have not been tested.
🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?