Async Substrate #1958
Merged
Async Substrate #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewhaleking
force-pushed
the
feature/thewhaleking/async-rpc-request
branch
from
9646b44 to
111c507
Compare
…equest' into feature/thewhaleking/async-rpc-request
…ake use of reuse last block hash cache.
…equest' into feature/thewhaleking/async-rpc-request
…leking/async-rpc-request # Conflicts: # bittensor/subtensor.py # bittensor/utils/async_substrate.py
There was a problem hiding this comment.
I left some list of comments. I just want us to adhere to standard, which we ourselves developed and adopted. We do not know how long we will have to work with this module and when the official release of Async SubstrateInterface will appear. Adhering to a coding standard will help us interact with this large codebase more easily and quickly.
Overall this is a stunning and excellent implementation 👍.
Thanks for this!
|
I opened the PR and executed the |
roman-opentensor
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an asyncio compatible RPC request functionality to replace that used by pysubstrate-interface.