Release/8.4.4

CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 8.4.4 /2024-12-05
+
+## What's Changed
+* Removes the call that automatically sets everything to warning level debugging by @thewhaleking in https://github.com/opentensor/bittensor/pull/2508
+* Exit `set_weights` on success by @thewhaleking in https://github.com/opentensor/bittensor/pull/2511
+* `test_dendrite` test clean up by @thewhaleking in https://github.com/opentensor/bittensor/pull/2512
+* Adds --logging.info level so it can be set @ibraheem-opentensor in https://github.com/opentensor/bittensor/pull/2510
+* Allows wallet to be created through configs in the axon if it is provided by @ibraheem-opentensor in https://github.com/opentensor/bittensor/pull/2510
+* Changes verbosity level of ClientConnectorError and TimeoutError in the dendrite to debug by @ibraheem-opentensor in https://github.com/opentensor/bittensor/pull/2510
+* Fixes behaviour of config initialization for axon, subtensor, logging and threadpool by @ibraheem-opentensor in https://github.com/opentensor/bittensor/pull/2510
+* metagraph sync fix by @thewhaleking in https://github.com/opentensor/bittensor/pull/2514
+* Remove metadata retrieval of custom errors from format_error_message by @thewhaleking in https://github.com/opentensor/bittensor/pull/2518
+* Backmerge master to staging for 8.4.4 by @ibraheem-opentensor in https://github.com/opentensor/bittensor/pull/2519
+* Updates bt-decode to 0.4.0 by @ibraheem-opentensor in https://github.com/opentensor/bittensor/pull/2520
+
+**Full Changelog**: https://github.com/opentensor/bittensor/compare/v8.4.3...v8.4.4
+
 ## 8.4.3 /2024-12-02
 
 ## What's Changed

VERSION

@@ -1 +1 @@
-8.4.3
+8.4.4

bittensor/core/async_subtensor.py

@@ -1184,11 +1184,9 @@ async def sign_and_send_extrinsic(
             if await response.is_success:
                 return True, ""
             else:
-                return False, format_error_message(
-                    await response.error_message, substrate=self.substrate
-                )
+                return False, format_error_message(await response.error_message)
         except SubstrateRequestException as e:
-            return False, format_error_message(e, substrate=self.substrate)
+            return False, format_error_message(e)
 
     async def get_children(self, hotkey: str, netuid: int) -> tuple[bool, list, str]:
         """
@@ -1218,7 +1216,7 @@ async def get_children(self, hotkey: str, netuid: int) -> tuple[bool, list, str]
             else:
                 return True, [], ""
         except SubstrateRequestException as e:
-            return False, [], format_error_message(e, self.substrate)
+            return False, [], format_error_message(e)
 
     async def get_subnet_hyperparameters(
         self, netuid: int, block_hash: Optional[str] = None, reuse_block: bool = False

bittensor/core/axon.py

@@ -341,7 +341,7 @@ def __init__(
         self.config = config  # type: ignore
 
         # Get wallet or use default.
-        self.wallet = wallet or Wallet()
+        self.wallet = wallet or Wallet(config=self.config)
 
         # Build axon objects.
         self.uuid = str(uuid.uuid1())
@@ -594,7 +594,7 @@ def config(cls) -> "Config":
         """
         parser = argparse.ArgumentParser()
         Axon.add_args(parser)  # Add specific axon-related arguments
-        return Config(parser, args=[])
+        return Config(parser)
 
     @classmethod
     def help(cls):

bittensor/core/dendrite.py

@@ -241,7 +241,10 @@ def log_exception(self, exception: Exception):
         """
         error_id = str(uuid.uuid4())
         error_type = exception.__class__.__name__
-        logging.error(f"{error_type}#{error_id}: {exception}")
+        if isinstance(exception, (aiohttp.ClientConnectorError, asyncio.TimeoutError)):
+            logging.debug(f"{error_type}#{error_id}: {exception}")
+        else:
+            logging.error(f"{error_type}#{error_id}: {exception}")
 
     def process_error_message(
         self,

bittensor/core/extrinsics/async_registration.py

@@ -85,9 +85,7 @@ async def _do_pow_register(
     # process if registration successful, try again if pow is still valid
     await response.process_events()
     if not await response.is_success:
-        return False, format_error_message(
-            error_message=await response.error_message, substrate=subtensor.substrate
-        )
+        return False, format_error_message(error_message=await response.error_message)
     # Successful registration
     else:
         return True, None

bittensor/core/extrinsics/async_root.py

@@ -171,9 +171,7 @@ async def _do_set_root_weights(
     if await response.is_success:
         return True, "Successfully set weights."
     else:
-        return False, format_error_message(
-            await response.error_message, substrate=subtensor.substrate
-        )
+        return False, format_error_message(await response.error_message)
 
 
 async def set_root_weights_extrinsic(
@@ -263,6 +261,6 @@ async def set_root_weights_extrinsic(
             return False
 
     except SubstrateRequestException as e:
-        fmt_err = format_error_message(e, subtensor.substrate)
+        fmt_err = format_error_message(e)
         logging.error(f":cross_mark: [red]Failed error:[/red] {fmt_err}")
         return False

bittensor/core/extrinsics/async_transfer.py

@@ -64,9 +64,7 @@ async def _do_transfer(
         return (
             False,
             "",
-            format_error_message(
-                await response.error_message, substrate=subtensor.substrate
-            ),
+            format_error_message(await response.error_message),
         )
 
 

bittensor/core/extrinsics/async_weights.py

@@ -77,9 +77,7 @@ async def _do_set_weights(
     if await response.is_success:
         return True, "Successfully set weights."
     else:
-        return False, format_error_message(
-            response.error_message, substrate=subtensor.substrate
-        )
+        return False, format_error_message(response.error_message)
 
 
 async def set_weights_extrinsic(
@@ -206,9 +204,7 @@ async def _do_commit_weights(
     if await response.is_success:
         return True, None
     else:
-        return False, format_error_message(
-            response.error_message, substrate=subtensor.substrate
-        )
+        return False, format_error_message(response.error_message)
 
 
 async def commit_weights_extrinsic(

bittensor/core/extrinsics/commit_weights.py

@@ -127,9 +127,7 @@ def commit_weights_extrinsic(
         logging.info(success_message)
         return True, success_message
     else:
-        error_message = format_error_message(
-            error_message, substrate=subtensor.substrate
-        )
+        error_message = format_error_message(error_message)
         logging.error(f"Failed to commit weights: {error_message}")
         return False, error_message
 
@@ -249,8 +247,6 @@ def reveal_weights_extrinsic(
         logging.info(success_message)
         return True, success_message
     else:
-        error_message = format_error_message(
-            error_message, substrate=subtensor.substrate
-        )
+        error_message = format_error_message(error_message)
         logging.error(f"Failed to reveal weights: {error_message}")
         return False, error_message

bittensor/core/extrinsics/registration.py

@@ -79,9 +79,7 @@ def _do_pow_register(
     # process if registration successful, try again if pow is still valid
     response.process_events()
     if not response.is_success:
-        return False, format_error_message(
-            response.error_message, substrate=self.substrate
-        )
+        return False, format_error_message(response.error_message)
     # Successful registration
     else:
         return True, None
@@ -310,9 +308,7 @@ def _do_burned_register(
     # process if registration successful, try again if pow is still valid
     response.process_events()
     if not response.is_success:
-        return False, format_error_message(
-            response.error_message, substrate=self.substrate
-        )
+        return False, format_error_message(response.error_message)
     # Successful registration
     else:
         return True, None

bittensor/core/extrinsics/root.py

@@ -46,9 +46,7 @@ def _do_root_register(
     # process if registration successful, try again if pow is still valid
     response.process_events()
     if not response.is_success:
-        return False, format_error_message(
-            response.error_message, substrate=self.substrate
-        )
+        return False, format_error_message(response.error_message)
     # Successful registration
     else:
         return True, None

bittensor/core/extrinsics/serving.py

@@ -181,9 +181,7 @@ def serve_extrinsic(
             )
             return True
         else:
-            logging.error(
-                f"Failed: {format_error_message(error_message, substrate=subtensor.substrate)}"
-            )
+            logging.error(f"Failed: {format_error_message(error_message)}")
             return False
     else:
         return True
@@ -301,9 +299,7 @@ def publish_metadata(
         if response.is_success:
             return True
         else:
-            raise MetadataError(
-                format_error_message(response.error_message, substrate=self.substrate)
-            )
+            raise MetadataError(format_error_message(response.error_message))
 
 
 # Community uses this function directly

bittensor/core/extrinsics/set_weights.py

@@ -96,9 +96,7 @@ def do_set_weights(
     if response.is_success:
         return True, "Successfully set weights."
     else:
-        return False, format_error_message(
-            response.error_message, substrate=self.substrate
-        )
+        return False, format_error_message(response.error_message)
 
 
 # Community uses this extrinsic directly and via `subtensor.set_weights`

bittensor/core/extrinsics/staking.py

@@ -59,9 +59,7 @@ def _do_stake(
     if response.is_success:
         return True
     else:
-        raise StakeError(
-            format_error_message(response.error_message, substrate=self.substrate)
-        )
+        raise StakeError(format_error_message(response.error_message))
 
 
 def _check_threshold_amount(

bittensor/core/extrinsics/transfer.py

@@ -185,7 +185,7 @@ def transfer_extrinsic(
             )
     else:
         logging.error(
-            f":cross_mark: [red]Failed[/red]: {format_error_message(error_message, substrate=subtensor.substrate)}"
+            f":cross_mark: [red]Failed[/red]: {format_error_message(error_message)}"
         )
 
     if success:

bittensor/core/extrinsics/unstaking.py

@@ -58,9 +58,7 @@ def _do_unstake(
     if response.is_success:
         return True
     else:
-        raise StakeError(
-            format_error_message(response.error_message, substrate=self.substrate)
-        )
+        raise StakeError(format_error_message(response.error_message))
 
 
 def _check_threshold_amount(subtensor: "Subtensor", stake_balance: "Balance") -> bool:

bittensor/core/extrinsics/utils.py

@@ -65,9 +65,7 @@ def submit():
                 wait_for_finalization=wait_for_finalization,
             )
         except SubstrateRequestException as e:
-            logging.error(
-                format_error_message(e.args[0], substrate=subtensor.substrate)
-            )
+            logging.error(format_error_message(e.args[0]))
             # Re-raise the exception for retrying of the extrinsic call. If we remove the retry logic,
             # the raise will need to be removed.
             raise