fix(2188): don't allow uvicorn to reconfigure event_loop_policy #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
#2188
Description of the Change
Pass
loop="none"to actually not allow uvicorn to set up event loop policy and use our default (at the moment asyncio patched with nest_asyncio)Alternate Designs
Patching
uvicorn(withuvloop) to benest_asynciocompatible.Possible Drawbacks
None
Verification Process
Running unittests & launching Axon (with and without
uvlooppackage installed) to see accepting incoming requests.Release Notes