[Common] port_id and parallel_edges_ids are added to the graph for analysis
#2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF Common
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2206 +/- ##
===========================================
- Coverage 36.63% 36.40% -0.23%
===========================================
Files 486 486
Lines 43377 43460 +83
===========================================
- Hits 15889 15821 -68
- Misses 27488 27639 +151
|
…or_structural_analysis
…or_structural_analysis
vshampor
requested changes
Oct 27, 2023
There was a problem hiding this comment.
So now all of the reference structural graphs except for torch use the format with port IDs and shapes, except for torch. Either regenerate torch reference graphs to the new format, or keep the old format in the other frameworks and only extend the reference graphs with the "parallel_input_port_ids".
nncf/common/graph/graph.py
Outdated
| @@ -607,12 +607,12 @@ def get_graph_for_structure_analysis(self, extended: bool = False) -> nx.DiGraph | |||
| else: | |||
| attrs_edge["style"] = "solid" | |||
| label["shape"] = edge[NNCFGraph.ACTIVATION_SHAPE_EDGE_ATTR] | |||
| label[ | |||
| "ports" | |||
| ] = f"{edge[NNCFGraph.OUTPUT_PORT_ID_EDGE_ATTR]}\u2192{edge[NNCFGraph.INPUT_PORT_ID_EDGE_ATTR]}" | |||
There was a problem hiding this comment.
I understand that you tried to make the representation prettier, but even in 2023 there's no guarantee that every tool can handle Unicode well enough. Use -> to represent an arrow, that would be safer.
daniil-lyakhov
force-pushed
the
dl/fix_get_graph_for_structural_analysis
branch
from
2fc08c9 to
11d3d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
port_idandparallel_edges_idsare added to the graph for analysisReason for changes
To test
parallel_edges_idsandport_idin graph tests as well as the structural information.Related tickets
Tests