[NNCF] NNCF common accuracy aware training code pass mypy checks #2521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2521 +/- ##
===========================================
- Coverage 90.91% 84.22% -6.70%
===========================================
Files 498 498
Lines 45526 45540 +14
===========================================
- Hits 41390 38354 -3036
- Misses 4136 7186 +3050
... and 72 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@siddhant-0707 please extend the |
| @@ -1,5 +1,5 @@ | |||
| [mypy] | |||
| files = nncf/common/sparsity | |||
| files = nncf/common/accuracy_aware_training | |||
There was a problem hiding this comment.
You shouldn't replace the path, you should extend it.
| @@ -127,8 +127,8 @@ def initialize_training_loop_fns( | |||
| validate_fn: Callable[[TModel, Optional[int]], float], | |||
| configure_optimizers_fn: Callable[[], Tuple[OptimizerType, LRSchedulerType]], | |||
| dump_checkpoint_fn: Callable[[TModel, CompressionAlgorithmController, "TrainingRunner", str], None], | |||
| **kwargs, | |||
| ): | |||
| **kwargs: Any, | |||
There was a problem hiding this comment.
This type hint is incorrect, review your general Python knowledge as to what type the **kwargs parameter is constrained to.
|
hey @siddhant-0707 will you have time to respond for changes request? |
Changes
Added type annotation to files in
nncf/common/accuracy_aware_training.Some checks still not passing mainly due to problem with class annotations.
Related tickets
#2492
Tests
mypy