Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Expose some advanced quantization parameters to be available as nncf.* #2628

Conversation

nikita-savelyevv
Copy link
Collaborator

Copy of #2624 to release branch.

openvinotoolkit#2624)

Follow-up to openvinotoolkit#2608.

### Changes

- Expose `AdvancedSmoothQuantParameters` and
`AdvancedBiasCorrectionParameters` to be available as
`nncf.AdvancedSmoothQuantParameters`,
`nncf.AdvancedBiasCorrectionParameters`.
- Inherit `QuantizationScheme` and `FP8Type` from `StrEnum`.

### Reason for changes

Improving NNCF UX.
@nikita-savelyevv nikita-savelyevv requested a review from a team as a code owner April 12, 2024 11:13
@github-actions github-actions bot added NNCF Common Pull request that updates NNCF Common NNCF PTQ Pull requests that updates NNCF PTQ labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (ec497ce) to head (b99c8c8).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release_v2100    #2628       +/-   ##
==================================================
- Coverage          91.16%   77.94%   -13.22%     
==================================================
  Files                494      494               
  Lines              45372    45374        +2     
==================================================
- Hits               41365    35369     -5996     
- Misses              4007    10005     +5998     
Files Coverage Δ
nncf/__init__.py 98.18% <100.00%> (+0.06%) ⬆️
nncf/common/quantization/structs.py 96.18% <100.00%> (ø)
nncf/quantization/advanced_parameters.py 85.80% <100.00%> (-6.18%) ⬇️

... and 103 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.12% <100.00%> (+<0.01%) ⬆️
TORCH 65.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.32% <100.00%> (-5.47%) ⬇️
torch 93.48% <ø> (-0.01%) ⬇️
tensorflow 93.74% <ø> (ø)
onnx 0.00% <ø> (-93.08%) ⬇️
openvino 25.76% <ø> (-68.41%) ⬇️
ptq 53.05% <100.00%> (-37.06%) ⬇️

@nikita-malininn nikita-malininn merged commit 8638ff0 into openvinotoolkit:release_v2100 Apr 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants