Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTQ] Add default batch sizes for PTQ conformance test #2643

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented Apr 19, 2024

Changes

Add default batch_size for calibration dataset for every model.
If model has no "batch_size" parameter meaning that it doesn't support batch_size > 1

Reason for changes

Speed up quantization

Related tickets

N/A

Tests

N/A

@kshpv kshpv requested a review from a team as a code owner April 19, 2024 08:52
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (96eef35) to head (d2081c7).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2643       +/-   ##
============================================
- Coverage    91.14%   77.95%   -13.19%     
============================================
  Files          494      493        -1     
  Lines        45421    45445       +24     
============================================
- Hits         41397    35428     -5969     
- Misses        4024    10017     +5993     

see 127 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.08% <ø> (-0.03%) ⬇️
TORCH 65.99% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.28% <ø> (-5.52%) ⬇️
torch 93.59% <ø> (+0.10%) ⬆️
tensorflow 93.74% <ø> (-0.01%) ⬇️
onnx 0.00% <ø> (-92.45%) ⬇️
openvino 25.67% <ø> (-68.50%) ⬇️
ptq 53.03% <ø> (-37.08%) ⬇️

@alexsu52 alexsu52 requested a review from KodiaqQ April 19, 2024 16:07
@kshpv kshpv force-pushed the conformance_default_bs branch 2 times, most recently from ae0a774 to fcd63fe Compare April 21, 2024 13:11
@kshpv
Copy link
Collaborator Author

kshpv commented Apr 22, 2024

job number 366 passed

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Apr 24, 2024

Are there any numbers that show speed up for the conformance runs?

@KodiaqQ KodiaqQ merged commit d10afcf into openvinotoolkit:develop Apr 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants