Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking model type in nncf.torch.wrap_model #2651

Merged

Conversation

alexsu52
Copy link
Contributor

Changes

Added model type check in nncf.torch.wrap_model

Reason for changes

Improve UX

Related tickets

#2636 (comment)

Tests

N/A

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.95%. Comparing base (fa1a4ce) to head (05e04c3).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2651       +/-   ##
============================================
- Coverage    89.84%   77.95%   -11.90%     
============================================
  Files          494      493        -1     
  Lines        45374    45447       +73     
============================================
- Hits         40768    35429     -5339     
- Misses        4606    10018     +5412     
Files Coverage Δ
nncf/torch/model_creation.py 91.22% <50.00%> (-0.74%) ⬇️

... and 108 files with indirect coverage changes

Flag Coverage Δ
ONNX ?
OPENVINO ?
TENSORFLOW 30.08% <0.00%> (-0.04%) ⬇️
TORCH 65.99% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.28% <ø> (-1.26%) ⬇️
torch 93.58% <50.00%> (+0.09%) ⬆️
tensorflow 93.74% <ø> (-0.01%) ⬇️
onnx 0.00% <ø> (-93.08%) ⬇️
openvino 25.67% <ø> (-68.50%) ⬇️
ptq 53.03% <ø> (-32.17%) ⬇️

nncf/torch/model_creation.py Outdated Show resolved Hide resolved
@AlexanderDokuchaev AlexanderDokuchaev merged commit 057c4ce into openvinotoolkit:develop Apr 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants