Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] nncf/common/quantization (part 1) #3192

Merged
merged 5 commits into from
Jan 17, 2025
Merged

[mypy] nncf/common/quantization (part 1) #3192

merged 5 commits into from
Jan 17, 2025

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Jan 15, 2025 •
edited
Loading

Changes

  1. Enable mypy for:
    • nncf/common/quantization/quantizers.py
    • nncf/common/quantization/statistics.py
    • nncf/common/quantization/structs.py
    • nncf/common/quantization/quantizer_propagation/structs.py
    • nncf/common/quantization/quantizer_propagation/visualizer.py
  2. Inheritance of QuantizationScheme from StrEnum Revert inheritance of QuantizationScheme from StrEnum #2629
  3. Add QuantizationScheme to Unpickler, to pass pt nightly

Tests

nightly/job/torch_nightly/438/

@github-actions github-actions bot added NNCF Common Pull request that updates NNCF Common API Public API-impacting changes labels Jan 15, 2025
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Jan 15, 2025
@AlexanderDokuchaev AlexanderDokuchaev changed the title [mypy] nncf/common/quantization [mypy] nncf/common/quantization (part 1) Jan 16, 2025
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review January 16, 2025 10:39
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner January 16, 2025 10:39
@AlexanderDokuchaev AlexanderDokuchaev requested review from andrey-churkin and removed request for a team January 16, 2025 10:39
andrey-churkin
andrey-churkin approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@andrey-churkin andrey-churkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderDokuchaev AlexanderDokuchaev merged commit 0b80812 into openvinotoolkit:develop Jan 17, 2025
17 checks passed
@AlexanderDokuchaev AlexanderDokuchaev mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-churkin andrey-churkin andrey-churkin approved these changes

@nikita-savelyevv nikita-savelyevv nikita-savelyevv approved these changes

Assignees
No one assigned
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderDokuchaev @nikita-savelyevv @andrey-churkin