Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Add GenAI Node.js bindings #1193

Merged
merged 98 commits into from
Jan 28, 2025
Merged

[JS] Add GenAI Node.js bindings #1193

merged 98 commits into from
Jan 28, 2025

Conversation

vishniakov-nikolai
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai commented Nov 11, 2024 •
edited
Loading

Adding Node.js bindings for GenAI pipelines.

  • 155187
  • 158132

Limitations

Current version it's primary backbone of future development. Supports bindings of LLMPipeline only.

TODO

  • Test build configuration
  • Integrate unit tests run into GHA
  • Add script to download runtime binaries (after binaries publication)

@github-actions github-actions bot added category: sampling Sampling / Decoding algorithms category: cmake / build Cmake scripts category: samples GenAI samples labels Nov 11, 2024
@ilya-lavrenov ilya-lavrenov removed the category: sampling Sampling / Decoding algorithms label Nov 20, 2024
@github-actions github-actions bot added the category: tokenizers Tokenizer class or submodule update label Nov 20, 2024
@vishniakov-nikolai vishniakov-nikolai marked this pull request as ready for review November 25, 2024 10:58
@github-actions github-actions bot added category: llm_bench Label for tool/llm_bench folder category: GHA CI based on Github actions labels Nov 26, 2024
ilya-lavrenov
ilya-lavrenov reviewed Jan 16, 2025
View reviewed changes
samples/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov self-requested a review January 16, 2025 12:14
@ilya-lavrenov ilya-lavrenov dismissed their stale review January 16, 2025 12:34

From integration perspective looks OK

@mlukasze mlukasze requested a review from mryzhov January 27, 2025 06:01
@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@vishniakov-nikolai vishniakov-nikolai added this to the 2025.1 milestone Jan 28, 2025
@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2025
@vishniakov-nikolai vishniakov-nikolai added this pull request to the merge queue Jan 28, 2025
Merged via the queue into openvinotoolkit:master with commit 4fb48de Jan 28, 2025
62 checks passed
@vishniakov-nikolai vishniakov-nikolai deleted the feature/nodejs-bindings branch January 28, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@Wovchena Wovchena Wovchena approved these changes

@as-suvorov as-suvorov Awaiting requested review from as-suvorov

@mryzhov mryzhov Awaiting requested review from mryzhov

Assignees

@ilya-lavrenov ilya-lavrenov

@Wovchena Wovchena

Labels
category: cmake / build Cmake scripts category: GHA CI based on Github actions category: samples GenAI samples no-match-files
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
4 participants
@vishniakov-nikolai @Wovchena @ilya-lavrenov @mryzhov