fill prompt for sampler analysis with real tokens in VLM pipeline #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbalandi
commented
Nov 22, 2024
•
sbalandi
commented
- add missed token, if prev generation was finished because max length was reached
| std::fill_n(prompt_ids.data<int64_t>(), prompt_ids.get_size(), 0); | ||
|
|
||
| auto chat_history = m_inputs_embedder->get_tokenized_chat_history(); | ||
| size_t chat_history_size = std::max(chat_history.get_shape().at(1), history_size + inputs_embeds_size); |
There was a problem hiding this comment.
looks like we have the same case as for LLMs, when decode ( encode ( X ) ) provides smaller value than X ?
in this case we need to partially re-compute the history.
There was a problem hiding this comment.
in general, I would consider merging VLM and LLM pipelines generate functions to keep all this magic with history in one place.
Or at least to create helper function similar to get_lm_encoded_results
There was a problem hiding this comment.
I'll try to merge some part here after #1215
sbalandi
force-pushed
the
vlm_mask_vs_hist
branch
from
15fdc3c to
2b26160
Compare
github-actions
bot
added
category: LLM
|
rebased on #1254 |
sbalandi
force-pushed
the
vlm_mask_vs_hist
branch
6 times, most recently
from
c6b1907 to
53cd2f7
Compare
sbalandi
force-pushed
the
vlm_mask_vs_hist
branch
2 times, most recently
from
22101ad to
a8b866c
Compare
ilya-lavrenov
approved these changes
Dec 18, 2024
Wovchena
approved these changes
Dec 18, 2024
sbalandi
force-pushed
the
vlm_mask_vs_hist
branch
from
71a7cd2 to
8a8e513
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.