Skip to content

Commit

Permalink
Fixed C++ RTTI for header only classes (#28624)
Browse files Browse the repository at this point in the history
### Details:
- Regression after
#28555
  • Loading branch information
ilya-lavrenov authored Jan 23, 2025
1 parent 6eda8ce commit 8dfb9cc
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 8 deletions.
3 changes: 3 additions & 0 deletions src/frontends/common/include/openvino/frontend/decoder.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ class FRONTEND_API DecoderBase : public IDecoder {

/// \brief Get node name
virtual const std::string& get_op_name() const = 0;

/// \brief Destructor
virtual ~DecoderBase();
};

} // namespace frontend
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,10 @@ class FRONTEND_API GraphIterator : ::ov::RuntimeAttribute {
virtual std::vector<std::string> get_output_names() const = 0;

/// \brief Returns a map from internal tensor name to (user-defined) external name for inputs
virtual std::map<std::string, std::string> get_input_names_map() const {
return {};
}
virtual std::map<std::string, std::string> get_input_names_map() const;

/// \brief Returns a map from internal tensor name to (user-defined) external name for outputs
virtual std::map<std::string, std::string> get_output_names_map() const {
return {};
}
virtual std::map<std::string, std::string> get_output_names_map() const;
};

} // namespace tensorflow
Expand Down
2 changes: 2 additions & 0 deletions src/frontends/common/src/decoder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@
using namespace ov::frontend;

IDecoder::~IDecoder() = default;

DecoderBase::~DecoderBase() = default;
15 changes: 15 additions & 0 deletions src/frontends/common/src/graph_iterator.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright (C) 2018-2025 Intel Corporation
// SPDX-License-Identifier: Apache-2.0
//

#include "openvino/frontend/graph_iterator.hpp"

using namespace ov::frontend::tensorflow;

std::map<std::string, std::string> GraphIterator::get_input_names_map() const {
return {};
}

std::map<std::string, std::string> GraphIterator::get_output_names_map() const {
return {};
}
2 changes: 1 addition & 1 deletion src/frontends/common/src/hash_table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@

using namespace ov::frontend;

HashTable::~HashTable(){};
HashTable::~HashTable() = default;
2 changes: 1 addition & 1 deletion src/frontends/pytorch/src/frontend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ ov::frontend::InputModel::Ptr FrontEnd::load_impl(const std::vector<ov::Any>& va
size_t extra_variants_num = variants.size() > 0 && variants[variants.size() - 1].is<bool>() ? 1 : 0;
FRONT_END_GENERAL_CHECK(variants.size() == 1 + extra_variants_num,
"PyTorch Frontend supports exactly one parameter in model representation, got ",
std::to_string(variants.size()),
variants.size(),
" instead.");
FRONT_END_GENERAL_CHECK(variants[0].is<std::shared_ptr<IDecoder>>(),
"PyTorch Frontend doesn't support provided model type. Please provide supported model "
Expand Down

0 comments on commit 8dfb9cc

Please sign in to comment.