Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] OV file utils file_size use std file path #28462
base: master
Are you sure you want to change the base?
[CORE] OV file utils file_size use std file path #28462
Changes from 9 commits
887dd2b
04671c7
b334528
c0ec93e
dce5d59
701cd96
97f2a96
c0345b1
66615dc
a1e8053
f34b2d2
2d071bf
3b2fbae
eed127e
067224b
22d6712
2e7cf52
e9c2cca
71e2206
c8bdb3b
dd13c04
74640d8
0f2aa4a
76d0a49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider add specialization for compiler version where is bug with path creation then
WPath
function is not required and path can be create always in same way.Optionally: If any issue because specialization already defined add some trait check to detect it and avoid define it in OV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not required can be still internal part of
file_size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably return the wrong variable (
file_name
instead offile_name_result
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should probably be wrapper to
std
implementation if works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formally tellg returns current position in stream and nothing more. It does not guarantee that this value is equal to the file size.
https://en.cppreference.com/w/cpp/io/basic_istream/tellg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is removed?
Should be marked deprecated first before we remove it, with information that will be removed in e.g. 2026.0
Consider add deprecation note to other function which are not using Path type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions are not cast rename file or keep them in original header.
Why these function are moved to new file?