Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippets][CPU] Fix int8 handling and disable snippets for unhandled types in callbacks #28596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snippets][CPU] Fix int8 handling and disable snippets for unhandled types in callbacks #28596

wants to merge 1 commit into from
+2 −2

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Jan 21, 2025 •
edited
Loading

Details:

  • Fix default return value in snippets callback on unhandled type (disable if the type is not explicitly supported)
  • Fix check for 8 bit integer values (handle both signed and unsigned)

Tickets:

  • 160487

@aobolensk aobolensk assigned aobolensk and unassigned aobolensk Jan 21, 2025
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 21, 2025
@aobolensk aobolensk marked this pull request as ready for review January 21, 2025 19:10
@aobolensk aobolensk requested review from a team as code owners January 21, 2025 19:10
@aobolensk aobolensk requested a review from v-Golubev January 21, 2025 19:10
@aobolensk aobolensk marked this pull request as draft January 21, 2025 20:56
@aobolensk aobolensk force-pushed the vnni-requirement-disable branch from 3487b35 to a37faf9 Compare January 23, 2025 12:03
@aobolensk aobolensk marked this pull request as ready for review January 23, 2025 12:03
@aobolensk aobolensk force-pushed the vnni-requirement-disable branch 2 times, most recently from cf54b28 to 0f5ea87 Compare January 23, 2025 12:25
@aobolensk aobolensk force-pushed the vnni-requirement-disable branch from 0f5ea87 to 0eeaed0 Compare January 23, 2025 14:53
@aobolensk aobolensk changed the title [Snippets][CPU] Disable VNNI requirement for i8 brgemm [Snippets][CPU] Fix int8 handling and disable snippets for unhandled types in callbacks Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-Golubev v-Golubev Awaiting requested review from v-Golubev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aobolensk