[GPU] add convert precision for converting bool to u8 #28654
Merged
+158
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnyoung-paul
added
category: GPU
yeonbok
reviewed
Jan 28, 2025
| false, | ||
| false, | ||
| false); | ||
|
|
There was a problem hiding this comment.
Can't we merge this change to the convertPrecision in the line452?
There was a problem hiding this comment.
I tried to merge this change to the line 452. but I think it is hard to merge because precision_map is different.
There was a problem hiding this comment.
However, I will try it again. thanks.
ahnyoung-paul
force-pushed
the
fix_bool_converting_issue
branch
from
27dc531 to
bbdcd9a
Compare
ahnyoung-paul
force-pushed
the
fix_bool_converting_issue
branch
from
bbdcd9a to
754456a
Compare
yeonbok
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: