-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX FE] Add SoftmaxCrossEntropyLoss operator to ONNX Frontend #28682
base: master
Are you sure you want to change the base?
[ONNX FE] Add SoftmaxCrossEntropyLoss operator to ONNX Frontend #28682
Conversation
Hi @gkrivor |
src/frontends/onnx/frontend/src/op/softmax_crossentropy_loss.cpp
Outdated
Show resolved
Hide resolved
Hello! It does have a CMakeLists.txt file, so I'm wondering if I could save time by doing that. |
Please bear with me for a while. My laptop's number keys just gave up and do not function anymore. And I have no external keyboard at the moment. It's going to take a while for my next update, after the servicing is over. |
7021ae0
to
451d0cb
Compare
451d0cb
to
d4ea9f1
Compare
Hello @rkazants ! |
4242b3c
to
c19673e
Compare
This pull request introduces the implementation of the Softmax Cross Entropy Loss operation for the ONNX frontend. The changes include adding new header and source files to define and implement the operation for two different opsets (12 and 13). The most important changes are as follows: Addition of new header and source files
Implementation details
I have a question about registering the operator registration. #include "op/org.openvinotoolkit/custom_add.hpp"
...
REGISTER_OPERATOR_WITH_DOMAIN(OPENVINO_ONNX_DOMAIN, "CustomAdd", 1, custom_add); But, ops_bridge.cpp looks different and leads to a dead end, quite different from the docs. But, when I compared And, I'd really appreciate it if there is a resource that will help me understand how to write the Thanks a bunch! |
093e1ac
to
a0019fa
Compare
a0019fa
to
d95757d
Compare
This pull request implements the SoftmaxCrossEntropyLoss operation for the ONNX frontend in OpenVINO, supporting opset 12 and opset 13. It includes new header and source files to define and implement the operation.
Ticket #20547
New operation implementation:
src/frontends/onnx/frontend/src/op/softmax_cross_entropy_loss.hpp
: Added the header file defining theSoftmaxCrossEntropyLoss
operation for opset 12 and opset 13.src/frontends/onnx/frontend/src/op/softmax_crossentropy_loss.cpp
: Added the source file implementing theSoftmaxCrossEntropyLoss
operation, including the shared helper functionimpl_softmax_cross_entropy
to compute the loss.TODO
softmax_cross_entropy_loss.cpp
&softmax_cross_entropy_loss.hpp
opset_12
&opset_13
P.S.: I'm very new to contributing to large codebases, and I want to know if my work meets the standards and most of all, is what's expected!