[DO NOT MERGE] ICU build from sources #387
Open
+619
−684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-normalization # Conflicts: # src/charsmap_normalization.cpp # tests/layer_tests.py
Support UnicodeNormalization and CaseFold operations using new backend. Do not use FastTokenizer dependency during build.
ilya-lavrenov
approved these changes
Jan 28, 2025
| @@ -176,10 +176,9 @@ jobs: | |||
| if-no-files-found: 'error' | |||
|
|
|||
| openvino_tokenizers_cpack: | |||
| name: OpenVINO tokenizers cpack (BUILD_FAST_TOKENIZERS=${{ matrix.build_fast_tokenizers }}, BUILD_TYPE=${{ matrix.build_type }}) | |||
| name: OpenVINO tokenizers cpack (BUILD_TYPE=${{ matrix.build_type }}) | |||
There was a problem hiding this comment.
please, drop these long names
| endif() | ||
|
|
||
| if(OPENVINO_RUNTIME_COMPILE_DEFINITIONS) | ||
| foreach(def ${OPENVINO_RUNTIME_COMPILE_DEFINITIONS}) |
There was a problem hiding this comment.
Suggested change
| foreach(def ${OPENVINO_RUNTIME_COMPILE_DEFINITIONS}) | |
| foreach(def IN LISTS OPENVINO_RUNTIME_COMPILE_DEFINITIONS) |
…mryzhov/openvino_tokenizers_public into icu_build_sources_fecth_content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those changes will be merged as part of #361. this PR for test purposes only