Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update Normalization: attempt 2" #395

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Revert "Update Normalization: attempt 2" #395

merged 1 commit into from
Feb 3, 2025

Conversation

rkazants
Copy link
Member

@rkazants rkazants commented Feb 3, 2025 •
edited
Loading

@rkazants rkazants requested a review from akladiev February 3, 2025 16:21
@rkazants rkazants mentioned this pull request Feb 3, 2025
Closed
@rkazants rkazants enabled auto-merge February 3, 2025 16:27
@pavel-esir
Copy link
Collaborator

We definitely should add TF layer tests check in tokenizers pre-commit

@andrei-kochin
Copy link
Collaborator

We definitely should add TF layer tests check in tokenizers pre-commit

@apaniukov

@rkazants rkazants enabled auto-merge February 3, 2025 16:37
@andrei-kochin andrei-kochin merged commit 0561f49 into master Feb 3, 2025
9 checks passed
@ilya-lavrenov ilya-lavrenov deleted the revert-394-cross-compilation branch February 3, 2025 18:10
mryzhov added a commit that referenced this pull request Feb 4, 2025
@mryzhov
Revert "Revert "Update Normalization: attempt 2 (#394)" (#395)"
02a39bc 
This reverts commit 0561f49.
@mryzhov mryzhov mentioned this pull request Feb 4, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
@apaniukov
Revert "Revert "Update Normalization"" (#401)
cc629ef 
* Revert "Revert "Update Normalization: attempt 2 (#394)" (#395)"

This reverts commit 0561f49

* Update TF Layer Tests CI Step

* Fix TF FE Layer Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-esir pavel-esir pavel-esir approved these changes

@akladiev akladiev akladiev approved these changes

@andrei-kochin andrei-kochin Awaiting requested review from andrei-kochin

Assignees
No one assigned
Labels
build CI tokenizers_cpp tokenizers_py tokenizers_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkazants @pavel-esir @andrei-kochin @akladiev