Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaskDINO Refactor #4006

Merged
merged 119 commits into from
Oct 28, 2024
Merged

MaskDINO Refactor #4006

merged 119 commits into from
Oct 28, 2024

Conversation

eugene123tw
Copy link
Collaborator

@eugene123tw eugene123tw commented Oct 8, 2024 •
edited
Loading

Summary

MaskDINO refactor PR specifically include the following:

  • Replaced detectron2.resnet with tv.resnet50
  • Organized shared files (e.g., position embeddings, visual encoder/decoder) under a common folder
  • Refactored the Hungarian matcher to incorporate mask cost and dice cost
  • Enhanced MaskDINOHead class with export and post-process functionality
  • Removed unnecessary code (batch norm, utility functions, box_ops, etc.) after refactoring
  • Modularized various MaskDINO head classes (maskdino_decoder, maskdino_encoder, maskdino_head)
  • Improved unit test cases for the MaskDINOHead, encoder, and decoder components

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

eugene123tw and others added 30 commits August 13, 2024 10:14
@eugene123tw
update
de84ae5
@eugene123tw
add pixel encoders and transformer encoders
faa52b4
@eugene123tw
update
8a164c0
@eugene123tw
format update
e845edd
@eugene123tw
reformat
81e3c99
@eugene123tw
add checkpoint loader
fd6fb91
@eugene123tw
add custom forward
5172d18
@eugene123tw
udpate
a3cfa15
@eugene123tw
update postprocess
e527126
@eugene123tw
fine tune model
1b95f6d
@eugene123tw
update criterion optimizers etc
3e43762
@eugene123tw
update loss
ffe4abb
@eugene123tw
replace MSDeformableAttention with native pytorch ops impl
dc40a19
@eugene123tw
add export functionality
cf364b9
@eugene123tw
roi align mask extraction
b9f9c9a
@eugene123tw
Revert "roi align mask extraction"
5efad89 
This reverts commit b9f9c9a.
@eugene123tw
Merge branch 'develop' into eugene/maskdino
3e9179f
@eugene123tw
update
eb8379b
@eugene123tw
Revert "update"
d9406f4 
This reverts commit eb8379b.
@eugene123tw
Merge branch 'develop' into eugene/maskdino
f84ee81
@sovrasov @eugene123tw
Upgrade OV, MAPI, and NNCF (openvinotoolkit#3967)
b7af978
@eugene123tw
Tiling Semantic Seg (openvinotoolkit#3954)
a69a1f1 
* tiling-semantic seg

* update recipe

* update unit test

* add unit test

* add test and test dataset

* update test

* refactor tests

* address some comments

* update tile adaptor

* add seg tiler test

* update src/otx/recipe/semantic_segmentation/dino_v2_tile.yaml

* update explain_mode
@eugene123tw
udpate
ac493ad
@eugene123tw
update maskdino from_config
0a6d834
@eugene123tw
update maskdino config
2c6ebcd
@eugene123tw
update maskdino config 2
183cc1c
@eugene123tw
Merge branch 'develop' into eugene/maskdino
13c9244
@eugene123tw
decouple detectron resnet50
1460c9c
@eugene123tw
decouple detectron resnet50
1083b2a
@eugene123tw
decouple detectron resnet50
c7f17d2
@eugene123tw eugene123tw requested review from sungchul2, kprokofi and eunwoosh and removed request for sungchul2 and kprokofi October 22, 2024 15:31
@sungchul2
Copy link
Contributor

sungchul2 commented Oct 24, 2024 •
edited
Loading

@eugene123tw could you describe the purpose and changes of this PR in Summary, and update CHANGELOG?

@github-actions github-actions bot added the DOC Improvements or additions to documentation label Oct 24, 2024
sungchul2
sungchul2 previously approved these changes Oct 25, 2024
View reviewed changes
@eugene123tw eugene123tw requested a review from sungchul2 October 25, 2024 10:44
@eugene123tw eugene123tw enabled auto-merge (squash) October 25, 2024 20:14
@eugene123tw eugene123tw merged commit f08e891 into openvinotoolkit:develop Oct 28, 2024
20 of 21 checks passed
@eugene123tw eugene123tw deleted the eugene/maskdino-optim branch October 28, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprokofi kprokofi kprokofi approved these changes

@sungchul2 sungchul2 sungchul2 approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@harimkang harimkang Awaiting requested review from harimkang

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily

@sovrasov sovrasov Awaiting requested review from sovrasov sovrasov is a code owner

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81

@yunchu yunchu Awaiting requested review from yunchu

@wonjuleee wonjuleee Awaiting requested review from wonjuleee

@eunwoosh eunwoosh Awaiting requested review from eunwoosh

Assignees
No one assigned
Labels
DOC Improvements or additions to documentation OTX 2.0 TEST Any changes in tests
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@eugene123tw @sungchul2 @kprokofi @eunwoosh @sovrasov