removed extra save method leading more writes on database #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Thank you @SitaGanesh, we need to add an assertion in the tests that checks the number of queries, comparing beforing and after this patch, there should be at least 1 less query.
The test method is called assertNumQueries.
Can you add this please?
|
Yes, Thankyou Sir @nemesifier I have some idea about this, but could you clarify me sir, which specific part of the code base this fix applies to? Is it related to the |
4 tasks
|
Sir @nemesifier, I have created a PR for tests that checks the number of queries, comparing beforing and after this patch. Refer to this #168 (2d36e61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(http://openwisp.io/docs/developer/contributing.html).
I have manually tested the changes proposed in this pull request.
I have written new test cases for new code and/or updated existing tests for changes to existing code.
I have updated the documentation.
Reference to Existing Issue
Closes #120.
Description of Changes
This pull request improves the efficiency of the save() method in the model. Combining multiple database operations into a single one reduces the number of database calls and improves performance.
Screenshot