[chores] Some requested changes

- Downgrade to python3.6
- Add qa checks for docs
- Fix failing build

.github/workflows/ci.yml

@@ -20,7 +20,7 @@ jobs:
       fail-fast: false
       matrix:
         python-version:
-          - 3.7
+          - 3.6
 
     steps:
     - uses: actions/checkout@v2
@@ -36,20 +36,16 @@ jobs:
       run: pip install -U "pip==20.2.4" wheel setuptools
 
     - name: Install netengine
-      run: |
-        pip install -e .
+      run: pip install -e .
 
     - name: Install test dependencies
-      run: |
-        pip install -U -r requirements-test.txt
+      run: pip install -U -r requirements-test.txt
 
     - name: Run QA Checks
-      run: |
-        ./run-qa-checks
+      run: ./run-qa-checks
 
     - name: Run tests
-      run: |
-        ./runtests.py
+      run: ./runtests.py
 
     - name: Upload Coverage
       run: coveralls --service=github

docs/source/topics/usage.rst

@@ -2,9 +2,11 @@
 Usage
 *****
 
-The usage of Netengine module requires it to be installed properly as explained in :ref:`index_reference`.
+The usage of Netengine module requires it to be installed properly as explained in :doc:`index<../index>`.
 If you have an installation under a virtualenv, enter the folder /bin and type::
-source activate
+
+    source activate
+
 otherwise (if you have installed globally) just open an editor as bpython and you we are ready to go.
 
 These are the main steps to follow to use the module:

requirements-test.txt

@@ -1,3 +1,4 @@
 nose~=1.3.7
 coverage~=5.5
+sphinx~=4.0.2
 openwisp-utils[qa]~=0.7.4

run-qa-checks

@@ -3,3 +3,7 @@
 set -e
 
 openwisp-qa-check --skip-checkmigrations
+
+# test sphinx docs
+mkdir -p docs/source/_static
+make -C docs html

setup.cfg

@@ -13,7 +13,6 @@ max-line-length = 110
 ignore = W605, W503, W504
 
 [isort]
-known_first_party = openwisp_utils
 line_length=88
 multi_line_output=3
 use_parentheses=True

tests/test_snmp/test_airos.py

@@ -1,4 +1,5 @@
 import unittest
+from unittest.mock import patch
 
 from pysnmp.entity.rfc3413.oneliner import cmdgen
 from pysnmp.smi.error import NoSuchObjectError
@@ -168,4 +169,4 @@ def test_uptime_tuple(self):
         self.assertIsInstance(self.device.uptime_tuple, tuple)
 
     def tearDown(self):
-        self.getcmd_patcher.stop()
+        patch.stopall()

tests/test_snmp/test_openwrt.py

@@ -1,4 +1,5 @@
 import unittest
+from unittest.mock import patch
 
 from pysnmp.entity.rfc3413.oneliner import cmdgen
 
@@ -106,4 +107,4 @@ def test_manufacturer_to_dict(self):
             self.assertIsNotNone(self.device.to_dict()['manufacturer'])
 
     def tearDown(self):
-        self.getcmd_patcher.stop()
+        patch.stopall()