Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update-config] Only remove items which are not in the downloaded configuration #73

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

okraits
Copy link
Member

@okraits okraits commented Oct 8, 2018

No description provided.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okraits great! 👍

Seems there's already an automated test for this feature, do you confirm?

Have you tried compiling this branch testing it on some device?

I'll need to do that as well but I guess I can do so next week.

@okraits
Copy link
Member Author

okraits commented Oct 9, 2018

@nemesisdesign Thank you 😃 I think that test_update_config.lua and possibly test_remove_default_wifi.lua are the relevant tests here. I ran the tests successfully.

I didn't build the package but I tested the changed file on a device. Looks good.

I think the next step will be to work on #72.

@nemesifier
Copy link
Member

nemesifier commented Oct 9, 2018

Great, does this patch help fixing #69?

@okraits
Copy link
Member Author

okraits commented Oct 9, 2018

Yes, it fixes #69. I did several tests and always examined the configuration before and after the tests. A section now won't be removed if it is included in the new, downloaded configuration and thus its position doesn't change.

@nemesifier
Copy link
Member

That's great news!

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nemesifier nemesifier merged commit 2a0008e into openwisp:master Oct 12, 2018
@okraits okraits deleted the tdt-fix-update-config branch October 15, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants