Poison "quantized int" specializations of std::is_signed, as a first step towards removing them. #21847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_719339288
branch
3 times, most recently
from
3efae36 to
d9c6862
Compare
…step towards removing them. This specialization is not permitted per the C++ standard, and thus: - MSVC silently ignores specializations of `std::is_signed`, since VS2019 16.4. - Clang emits `error: 'is_signed' cannot be specialized: Users are not allowed to specialize this standard library entity [-Winvalid-specialization]` by default, as of Clang 20. Also, modify all relevant callers of `std::is_signed<T>` for which the change triggered a compilation failure to instead call `std::numeric_limits<T>::is_signed`. Note that `std::numeric_limits` _is_ permitted to be specialized for user types. PiperOrigin-RevId: 720602373
copybara-service
bot
force-pushed
the
test_719339288
branch
from
d9c6862 to
bb8a7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poison "quantized int" specializations of std::is_signed, as a first step towards removing them.
This specialization is not permitted per the C++ standard, and thus:
std::is_signed, since VS2019 16.4.error: 'is_signed' cannot be specialized: Users are not allowed to specialize this standard library entity [-Winvalid-specialization]by default, as of Clang 20.Also, modify all relevant callers of
std::is_signed<T>for which the change triggered a compilation failure to instead callstd::numeric_limits<T>::is_signed.Note that
std::numeric_limitsis permitted to be specialized for user types.