Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: remove empty zpool_add--allow-ashift-mismatch test #16931

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

robn
Copy link
Member

@robn robn commented Jan 7, 2025

Motivation and Context

Found this weird empty test that confused me. I wanted to not be confused.

#15509 added this empty test. I don't know if it was meant to have stuff in it, but it doesn't, so there's no point keep it around.

@grwilson if it was a mistake, and you do have a nice test lying around somewhere, it'd be great if you could post it and I'll close this out.

Description

Remove the test and ZTS boilerplate for it.

How Has This Been Tested?

Ran zpool_add test tag by hand, all passed (except the one expected failure, natch).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Added in b1e46f8, but empty, so no point keeping it around.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <[email protected]>
@robn robn requested a review from grwilson January 7, 2025 09:58
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jan 7, 2025
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. We can always add this back in George has a version of this.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 7, 2025
@behlendorf behlendorf merged commit b8e09c7 into openzfs:master Jan 7, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants