Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: sets supported JDK range explicitly to 11,15 #3607

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Dec 2, 2023

Before, we were using an implicit version of the JDK when releasing, had
the pom.xml limited to a non-LTS version (15).

This sets the same up explicitly in CI, and corrects CI to use latest
action versions and ubuntu. A later change should update the ceiling
build version to an LTS, at least 17 if not 21. Currently, we can't as
there is a compilation failure. I'll look into it personally in the next
PR.

@codefromthecrypt
Copy link
Member Author

draft until green

Before, we were using an implicit version of the JDK when releasing, had
the pom.xml limited to a non-LTS version (15).

This sets the same up explicitly in CI, and corrects CI to use latest
action versions and ubuntu. A later change should update the ceiling
build version to an LTS, at least 17 if not 21. Currently, we can't as
there is a compilation failure. I'll look into it personally in the next
PR.

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt changed the title Sets supported JDK range explicitly to 11-17 ci: sets supported JDK range explicitly to 11,15 Dec 2, 2023
Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt marked this pull request as ready for review December 2, 2023 14:11
@codefromthecrypt
Copy link
Member Author

thanks for the look yet again @anuraaga!

@codefromthecrypt codefromthecrypt merged commit 18102bc into master Dec 2, 2023
9 checks passed
@codefromthecrypt codefromthecrypt deleted the gha-bump branch December 2, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants