Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates libs and fixes broken benchmarks #3619

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Dec 6, 2023

This fixes some benchmark glitches except ServerIntegratedBenchmark, which has been punted to a different issue, and doesn't technically affect benchmarks. This also fixes some dependency alignments along the way.

fixes #3588

@codefromthecrypt codefromthecrypt changed the title fixes broken benchmarks deps: updates libs and fixes broken benchmarks Dec 14, 2023
@codefromthecrypt codefromthecrypt marked this pull request as ready for review December 14, 2023 09:37
@@ -4678,7 +4678,7 @@
"babel-plugin-syntax-jsx": {
"version": "6.18.0",
"resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz",
"integrity": "sha512-qrPaCSo9c8RHNRHIotaufGbuOBN8rtdC4QrrFFc43vyWCCz7Kl7GL1PGaXtMGQZUXrkCjNEgxDfmAuAabr/rlw=="
"integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY="
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was created by node run in the frontend-maven-plugin, which uses sha1 at the moment.

@codefromthecrypt codefromthecrypt marked this pull request as draft December 14, 2023 09:46
This fixes some benchmark glitches except possibly
ServerIntegratedBenchmark, which is more a test than a benchmark. This
fixes some dependency alignments along the way.

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt marked this pull request as ready for review December 14, 2023 10:10
@codefromthecrypt codefromthecrypt merged commit 6932452 into master Dec 14, 2023
11 checks passed
@codefromthecrypt codefromthecrypt deleted the fix-bench branch December 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark throws exception "always scope with ActuateCollectorMetrics.forTransport"
1 participant