Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AssertJ best practices #3630

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

codefromthecrypt
Copy link
Member

Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/z3zoRjfC4

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(still) looks good to me. Thanks for including this!

@codefromthecrypt codefromthecrypt merged commit ad0615a into master Dec 12, 2023
10 checks passed
@codefromthecrypt codefromthecrypt deleted the refactor/assertj-best-practices branch December 12, 2023 23:27
@codefromthecrypt
Copy link
Member Author

Thanks for your help on the cleanups. If you see any low-hanging fruit, feel free to give more a try @timtebeek!

@timtebeek
Copy link
Contributor

Sure! I'll see what pops up tomorrow. And inversely, if you have any API changes you'd want to automate for your users do reach out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants