Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: changes to armeria-brave6 #3716

Merged
merged 1 commit into from
Feb 8, 2024
Merged

deps: changes to armeria-brave6 #3716

merged 1 commit into from
Feb 8, 2024

Conversation

codefromthecrypt
Copy link
Member

com.linecorp.armeria:armeria-brave now defaults to brave 5, which in the server is no problem as we imported the brave bom. however, to prevent accidents we should depend on the replacement com.linecorp.armeria:armeria-brave6

< [INFO] +- com.linecorp.armeria:armeria-brave:jar:1.27.1:compile
< [INFO] |  \- com.linecorp.armeria:armeria-brave5:jar:1.27.1:compile
< [INFO] |     \- io.zipkin.brave:brave-instrumentation-http:jar:6.0.0:compile
---
> [INFO] +- com.linecorp.armeria:armeria-brave6:jar:1.27.1:compile
> [INFO] |  \- io.zipkin.brave:brave-instrumentation-http:jar:6.0.0:compile

See line/armeria#5438 cc @openzipkin/armeria as if any of you are using instrumentation, you should make sure to change your deps similarly or get no free version updates from armeria anymore!

@codefromthecrypt codefromthecrypt merged commit 38fd611 into master Feb 8, 2024
12 checks passed
@codefromthecrypt codefromthecrypt deleted the armeria-brave6 branch February 8, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant