Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source: change menu structure "other types" -> "devices" for clarity #643

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

fichtner
Copy link
Member

@fichtner fichtner commented Dec 4, 2024

For opnsense/core#7446

TODO:

  • review current PPP pages (removed unreachable interface settings, but need to add a device page for it)
  • remove "use IPv4 connectivity" mentions
  • change PPPoE creation workflows (there is none that is explicit!)

@fichtner fichtner requested a review from Monviech December 4, 2024 18:40
@fichtner fichtner self-assigned this Dec 4, 2024
@Monviech
Copy link
Member

Monviech commented Dec 5, 2024

Maybe you could deprecate the source/manual/other-interfaces.rst document by emptying it and saying

"This page moved to "LINK""

@fichtner
Copy link
Member Author

fichtner commented Dec 5, 2024

Could do, but to be frank this is simpler. I'm not overly attached to having the right document name. The content matters (same with static PHP pages in the GUI we have not renamed because it doesn't bring any noticeable benefit).

Copy link
Member

@Monviech Monviech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants