Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composed groups #111

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add composed groups #111

merged 3 commits into from
Aug 26, 2024

Conversation

BeArchiTek
Copy link
Contributor

Related Issue

Closes #109

New Behavior

Adding the group keyword into the inventory plugin

Changes to the Documentation

Inventory plugin documentation regenerated

Proposed Release Note Entry

@BeArchiTek BeArchiTek requested a review from a team August 26, 2024 14:14
@BeArchiTek BeArchiTek self-assigned this Aug 26, 2024
@BeArchiTek BeArchiTek added changes/minor Feature Enhancements type/feature New feature or request labels Aug 26, 2024
wvandeun
wvandeun approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@wvandeun wvandeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to have some documentation on hwat that groups dictionary should look like?!

@BeArchiTek BeArchiTek merged commit a0da16a into develop Aug 26, 2024
10 checks passed
@BeArchiTek BeArchiTek deleted the add-composed-groups branch November 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvandeun wvandeun wvandeun approved these changes

Assignees

@BeArchiTek BeArchiTek

Labels
changes/minor Feature Enhancements type/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support groups option in inventory
2 participants
@BeArchiTek @wvandeun