Bump sdk to v1.4.1 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragmentedPacket
approved these changes
Jan 8, 2025
wvandeun
requested changes
Jan 8, 2025
wvandeun
reviewed
Jan 8, 2025
|
@FragmentedPacket not sure about the try/except logic. We would need to this everywhere we do that import (tests) as well. Maybe we should just set the min version of the SDK. I think, for now this should be ok. I don't think we want to maintain to much of a backwards compatibility anyway. Things are still changing quite a bit anyway. So this shouldn't be to big of a problem. |
nornir-automation/nornir#917 nornir should add this as a dependency which will happen in the new 3.5.0 release
v1.3.0 introduces new pydantic models for different schema related models that we need to use in this project
wvandeun
force-pushed
the
bgi-bump-sdk-1.3
branch
from
97956e7 to
875c91f
Compare
wvandeun
force-pushed
the
bgi-bump-sdk-1.3
branch
from
875c91f to
3afb81f
Compare
wvandeun
approved these changes
Jan 9, 2025
FragmentedPacket
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.