Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deno ci #209

Closed
wants to merge 3 commits into from
Closed

feat: deno ci #209

wants to merge 3 commits into from

Conversation

marco-ippolito
Copy link
Contributor

@marco-ippolito marco-ippolito commented Dec 10, 2022 •
edited
Loading

Resolves: #187
I'm creating this pull request to support a ci for deno
It seems to be working although setup-deno action does not support natively caching like setup-node.
There is a issue on this topic on setup-deno: denoland/setup-deno#31
Here a successful run on the fork: https://github.com/marco-ippolito/lyra/actions/runs/3663984022
I've also renamed the github actions for more clarity and corrected a typo.
Also I'm not sure this is the correct approach...

@marco-ippolito marco-ippolito marked this pull request as ready for review December 10, 2022 11:27
@marco-ippolito
Copy link
Contributor Author

I've added a broken package to make sure pnpm behaviour was correct https://github.com/LyraSearch/lyra/actions/runs/3693217103/jobs/6252948194

@micheleriva
Copy link
Member

@marco-ippolito looks too good to be true 🙂 I guess we can merge it! Could you revert your last commit?

@marco-ippolito
fix: renamed deno tests
4e84f65 
test: make pnpm fail

Revert "test: make pnpm fail"

This reverts commit cd3d1ed.

test: check deno presence

Revert "test: check deno presence"

This reverts commit c1edf34.
@marco-ippolito
test: check process arg
ddd26b3
@marco-ippolito
Copy link
Contributor Author

marco-ippolito commented Dec 14, 2022 •
edited
Loading

its using node :(
It seems node is installed by default on the github action machine.
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md

> c8 -c tests/config/c8-local.json tap --rcfile=tests/config/tap.yml tests/*.test.ts


    process arg /usr/local/bin/node
tests/deno.test.ts

@marco-ippolito marco-ippolito mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheleriva micheleriva micheleriva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a CI process for testing Lyra on Deno
2 participants
@marco-ippolito @micheleriva