fix: Perform-tasks fails when creating/updating stacks with large templates to 2+ regions #569 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… template to 2+ regions region is not being passed as an argument to GetCredentialProviderWithRoleAssumptions when building the cacheKey. This results in a cached S3Client being returned when a new one should be built for the 2nd region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
A new
S3Clientneeds to be constructed whenever the template is uploaded to a new region. This isn't currently happening becauseregionis not being passed as an argument toGetCredentialProviderWithRoleAssumptionswhen building thecacheKeywithin theGetS3Servicefunction. This results inGetS3Servicenot seeing the request as a newcacheKeyand the firstS3Clientis reused when it should not be.