Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return HTTP 400 if key unmarshal fails #3594

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

nipsufn
Copy link
Contributor

@nipsufn nipsufn commented Oct 25, 2023

This should correct behavior where on key unmarshal error application returns HTTP 500.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@nipsufn nipsufn force-pushed the fix/keyfile-unmarshall-400 branch from 363a7cc to 31115ff Compare October 25, 2023 07:13
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3594 (6b2ce92) into master (6a0a914) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6b2ce92 differs from pull request most recent head 170f312. Consider uploading reports for the commit 170f312 to get more accurate results

@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
+ Coverage   78.22%   78.24%   +0.01%     
==========================================
  Files         341      341              
  Lines       23141    23098      -43     
==========================================
- Hits        18103    18073      -30     
+ Misses       3681     3673       -8     
+ Partials     1357     1352       -5     

see 3 files with indirect coverage changes

@nipsufn nipsufn marked this pull request as ready for review October 25, 2023 12:39
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Just a small comment.

session/tokenizer.go Outdated Show resolved Hide resolved
@nipsufn nipsufn marked this pull request as draft October 26, 2023 10:25
@nipsufn nipsufn marked this pull request as ready for review October 27, 2023 06:26
@nipsufn nipsufn requested a review from hperl October 27, 2023 08:38
@hperl hperl enabled auto-merge (squash) October 27, 2023 10:21
@hperl hperl merged commit fdf4956 into ory:master Oct 27, 2023
26 checks passed
@nipsufn nipsufn deleted the fix/keyfile-unmarshall-400 branch October 4, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants