feat: parametrize courier worker #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows one to parametrize how many messages the courier will fetch and how often it will fetch messages.
7 tasks
zepatrik
reviewed
Oct 30, 2023
Comment on lines
+80
to
+81
| ViperKeyCourierWorkerPullCount = "courier.worker.pull_count" | ||
| ViperKeyCourierWorkerPullWait = "courier.worker.pull_wait" |
There was a problem hiding this comment.
Shouldn't this rather be poll?
There was a problem hiding this comment.
Hm I think polling is more when you ask a server / component whether they're ready periodically, and pulling refers to retrieving data and altering state. But really I don't care either way :)
There was a problem hiding this comment.
Yeah, both would work in this case I think...
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
==========================================
+ Coverage 78.21% 78.22% +0.01%
==========================================
Files 341 341
Lines 23136 23142 +6
==========================================
+ Hits 18095 18103 +8
Misses 3686 3686
+ Partials 1355 1353 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows one to parametrize how many messages the courier will fetch and how often it will fetch messages.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments