Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved webhook tracing #3746

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: improved webhook tracing #3746

merged 1 commit into from
Feb 12, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Feb 7, 2024

@alnr alnr self-assigned this Feb 7, 2024
@alnr alnr force-pushed the alnr/webhook-trace branch from e45cbba to 3bd7c7b Compare February 8, 2024 11:37
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (af55834) 78.34% compared to head (3bd7c7b) 78.38%.
Report is 4 commits behind head on master.

Files Patch % Lines
persistence/sql/identity/persister_identity.go 96.15% 3 Missing ⚠️
persistence/sql/persister_login_code.go 75.00% 2 Missing ⚠️
persistence/sql/persister_recovery.go 87.50% 2 Missing ⚠️
persistence/sql/persister_verification.go 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3746      +/-   ##
==========================================
+ Coverage   78.34%   78.38%   +0.03%     
==========================================
  Files         347      347              
  Lines       23827    23877      +50     
==========================================
+ Hits        18667    18715      +48     
- Misses       3750     3752       +2     
  Partials     1410     1410              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

driver/registry_default.go Show resolved Hide resolved
selfservice/hook/web_hook.go Show resolved Hide resolved
@aeneasr aeneasr merged commit 9d7021d into master Feb 12, 2024
29 checks passed
@aeneasr aeneasr deleted the alnr/webhook-trace branch February 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants