Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fewer DB loads when linking credentials, add tracing #4252

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Dec 24, 2024

No description provided.

@alnr alnr self-assigned this Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (85a7071) to head (08620cb).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/flow/login/hook.go 62.50% 2 Missing and 1 partial ⚠️
selfservice/strategy/oidc/strategy.go 62.50% 2 Missing and 1 partial ⚠️
selfservice/strategy/oidc/strategy_settings.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4252      +/-   ##
==========================================
+ Coverage   78.61%   78.62%   +0.01%     
==========================================
  Files         381      381              
  Lines       27372    27380       +8     
==========================================
+ Hits        21518    21528      +10     
  Misses       4233     4233              
+ Partials     1621     1619       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alnr alnr merged commit 2c5bb21 into master Jan 2, 2025
30 of 31 checks passed
@alnr alnr deleted the alnr/link-credentials-optimization branch January 2, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants