Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider only non-empty values when parsing pagination parameters from URLs #752

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jan 4, 2024

No description provided.

@alnr alnr self-assigned this Jan 4, 2024
@alnr alnr force-pushed the empty-pagination-parameters branch from 164edc3 to e7291b9 Compare January 4, 2024 10:57
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a page token constructor for UUIDs that rejects invalid UUIDs?

@alnr
Copy link
Contributor Author

alnr commented Jan 4, 2024

Would it make sense to have a page token constructor for UUIDs that rejects invalid UUIDs?

Medium-term, we'll probably end up using the MapPageToken utility more and more. For ordering by creation date and so on. UUID validation makes sense to me in that context 👍

@alnr alnr merged commit 728f15d into master Jan 4, 2024
8 checks passed
@alnr alnr deleted the empty-pagination-parameters branch January 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants