Fix and validate AppStream metainfo

- Add missing XML header - Validate format as per documentation: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
osbuild · Feb 11, 2019 · ad0e12a · ad0e12a
1 parent 7cda21b
commit ad0e12a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/Dockerfile.buildrpm b/Dockerfile.buildrpm
@@ -4,7 +4,7 @@ LABEL maintainer="Xiaofeng Wang" \
       baseimage="Fedora:latest" \
       description="A cockpit-composer RPM builder container running on Fedora"
 
-RUN dnf install -y make cmake rpm-build which gnupg tar xz curl jq nodejs python gcc gcc-c++ && dnf clean all
+RUN dnf install -y make cmake rpm-build which gnupg tar xz curl jq nodejs python gcc gcc-c++ libappstream-glib && dnf clean all
 
 WORKDIR /welder
 CMD ["make", "rpm", "srpm"]
diff --git a/cockpit-composer.spec.in b/cockpit-composer.spec.in
@@ -8,6 +8,7 @@ URL:            http://weldr.io/
 Source0:        https://github.com/weldr/welder-web/releases/download/%{version}/cockpit-composer-%{version}.tar.gz
 
 BuildArch:      noarch
+BuildRequires:  libappstream-glib
 
 Requires:       cockpit
 Requires:       lorax-composer
@@ -25,6 +26,7 @@ Composer GUI for Cockpit and lorax-composer
 mkdir -p %{buildroot}/%{_datadir}/cockpit/welder
 cp -r public/dist/* %{buildroot}/%{_datadir}/cockpit/welder
 mkdir -p %{buildroot}/%{_datadir}/metainfo/
+appstream-util validate-relax --nonet io.weldr.cockpit-composer.metainfo.xml
 cp io.weldr.cockpit-composer.metainfo.xml %{buildroot}/%{_datadir}/metainfo/
 
 %files

diff --git a/io.weldr.cockpit-composer.metainfo.xml b/io.weldr.cockpit-composer.metainfo.xml
@@ -1,3 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
 <component type="addon">
   <id>io.weldr.cockpit-composer</id>
   <metadata_license>CC0-1.0</metadata_license>