disk: enable customizing ESP partitions #1116
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
reviewed
Jan 6, 2025
| // Examples: | ||
| // 3B8F8425-20E0-4F3B-907F-1A25A76F98E8 (/srv on GPT) | ||
| // 06 (FAT16 on DOS) | ||
| GUID string `json:"guid,omitempty" toml:"guid,omitempty"` |
There was a problem hiding this comment.
I don't like calling this a GUID when it isn't always a GUID. In other places this is called Type, but that's obviously already been used. Maybe PartType?
People need to customize partitition types/GUIDs, so this commit adds this option to the blueprint. It's technically a partition type for DOS partitions, but the key type is already taken, so let's go with guid both for DOS and GPT.
This commit takes the blueprint customization added in the last commit, and makes it actually useful.
This commits allow people to customize their ESP partition. Previously, we always added an ESP partition ourselves, regardless of the given customizations, so the customization errored out if there was an ESP because of a conflict. This commit alters the behaviour, so ESP is only added automatically if it's not in the customizations.
|
Rebased due to image build cache layout change (#1130) |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits allow people to customize their ESP partition. Previously,
we always added an ESP partition ourselves, regardless of the given
customizations, so the customization errored out if there was an ESP
because of a conflict. This commit alters the behaviour, so ESP is
only added automatically if it's not in the customizations.
Based on #1115.