[RFC] osbuild: define the minimum osbuild version and enforce it #1194
Conversation
Define a new constant in the `osbuild` package for the minimum osbuild version supported by the package. Enforce the minimum version when executing osbuild. This has the potential to prevent surprises when using older osbuild with `images` implementation that relies on changes in a newer version of osbuild. This will allow dependent projects to extract the minimum version and check if their packaging requirements are up to date with the version of `images` that they depend on. Signed-off-by: Tomáš Hozza <[email protected]>
There was a problem hiding this comment.
Ok, this makes sense, I like it.
One thing I would change though is to probably put the minimum version in a text file and compile it in with go:embed, just for visibility and to make it easier to work with in some automated way. For example, if we want to read it during some testing, or if someone is browsing the repo to find it, it would be a lot easier to be able to point to something like res/osbuild-min-version. We could even link to it from the README or some docs without needing to point to specific lines in code.
Great idea! |
Define a new constant in the
osbuildpackage for the minimum osbuild version supported by the package. Enforce the minimum version when executing osbuild.This has the potential to prevent surprises when using older osbuild with
imagesimplementation that relies on changes in a newer version of osbuild.This will allow dependent projects to extract the minimum version and check if their packaging requirements are up to date with the version of
imagesthat they depend on.My plan would be to then have a GH action in
osbuild-composerandimage-builder-clito check if the SPEC file requires osbuild of at leastMinimumOSBuildVersionversion, but in practice, CI tests building any images would fail as well.