Изменен ПровайдерПараметровJSON.os #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- вместо пакета json переделал на нативное ЧтениеJSON
|
В идеале, конечно, вариант 3. :) |
- чтение в соответствие вместо структуры
принял. пока пофиксил соответствие, чтобы тесты позеленели. |
|
Закрываю в пользу #37. Спасибо за инициацию расследования! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
вместо пакета json переделал на нативное ЧтениеJSON, так как в некоторых окружениях чтение зависало на файле размером в 200 килобайт.
на данный момент использование пакета json осталось только в тестах.
предполагаю 3 варианта:
как лучше поступить?