Feature: Destructured imports in variable declarations, Refactor parser with Babel type guards #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enabled strict mode for extension. - Relaxed some superfluous style rules. - Set eslint scope to include webviews/.
- Record<string, unknown> is default recommended by @typescript-eslint/ban-types. - Using Array<T> when T is composite data type, and T[] when T is primitive is useful visual cue.
- test 14: Subset of require() syntax a) object destructuring with alias assignment b) array destructuring - test 15: Subset of variable declaration import a) object destructuring alias assignment b) array destructuring
- Extensive rewrites in getImports(), findVarDecImports() methods - Explicit checks with strong typing for most import statement variations - Readability, modularity, extensibility improvements
- Newly supports a subset of require() syntax
a) DOES support object destructuring with alias assignment
* e.g. const { foo: alias, bar } = require("./module")
b) DOES support array destructuring
* e.g. const [foo, bar] = require("./module")
c) DOES NOT support namespaces and member expressions
* e.g. const foo = require("./module"); ... ; <foo.component />;
d) DOES NOT support invocations or method/member calls
* e.g. const foo = require("./module")();
* e.g. const foo = require("./module").method(arg);
- Newly supports a subset of variable declaration imports
a) DOES support object destructuring with alias assignment, and array destructuring
* no actual use cases, but intermediate step towards fully supporting dynamic imports
* e.g. const { foo: alias, bar } = import("./module")
* e.g. const [foo, bar] = import("./module")
- DOES NOT support await expressions, .then() chains, or Promise.resolve() calls for dynamic imports
* e.g. const foo = await import("./module")
* e.g. import("./module").then(mod => mod.loadPage())
* e.g. const foo = Promise.resolve(import("./module"))
- reserve parentheses for capture+backreference where possible
- convention for descriptive variable naming - encountered issues with testing resolved by purging out/, dist/
MajorLift
force-pushed
the
feature/parser/type-guards,require,variable-declaration-imports
branch
from
0937c64 to
ad75e04
Compare
|
@PLCoster is anyone maintaining this repo? It seems like a really useful tool, but is not currently very useful without addressing this issue, which may be solved by this PR. |
|
This PR lays some groundwork for eventually supporting barrel files, but isn't a full fix for the issue. |
MajorLift
deleted the
feature/parser/type-guards,require,variable-declaration-imports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love this project, and having a ton of fun going through the code!
1) Features
Newly supports a subset of
require()syntaxconst { foo: alias, bar } = require("./module")const [foo, bar] = require("./module")const foo = require("./module"); ... ; <foo.component />;const foo = require("./module")();const foo = require("./module").method(arg);Newly supports a subset of variable declaration imports
(no actual use cases, but intermediate step towards fully supporting dynamic imports)
const { foo: alias, bar } = import("./module")const [foo, bar] = import("./module")const foo = await import("./module")import("./module").then(mod => mod.loadPage())const foo = Promise.resolve(import("./module"))2) SaplingParser
3) Strict Typescript linter settings
Water for the tree :)