Bring current with SDK internalization #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add changelog entry for 0.17.3 * Update CHANGELOG.md
…ffer (cosmos#452) After a bytes.Buffer has been freshly created, there is no need to invoke .Reset. Fixes cosmos#451
* reuse buffer * copy bytes
…mos#456) The prior code used a naive string concatenation str += "..." which is very slow and inefficient especially when iterating over all the keys, but also it performed an unnecessary byteslice->string conversion for all arguments inside (nodeDB).traverse* using str += fmt.Sprintf("%s: %x\n", string(key), value) notice the `string(key)` passed into fmt.Sprintf("%s"? At bare minimum that code should just simply be: str += fmt.Sprintf("%s: %x\n", key, value) per https://twitter.com/orijtech/status/1462100381803102213?s=20 which saves a whole lot of cycles and RAM. This change uses: * (*bytes.Buffer) in combination with fmt.Fprintf * A sync.Pool with (*bytes.Buffer) values to reuse buffers and the results are profound: ```shell $ benchstat before.txt after.txt name old time/op new time/op delta TreeString-8 111ms ± 8% 4ms ± 4% -96.01% (p=0.000 n=20+20) name old alloc/op new alloc/op delta TreeString-8 734MB ± 0% 2MB ± 1% -99.72% (p=0.000 n=20+20) name old allocs/op new allocs/op delta TreeString-8 37.0k ± 0% 28.7k ± 0% -22.40% (p=0.000 n=20+20) ``` Fixes cosmos#455
Bumps [docker/login-action](https://github.com/docker/login-action) from 1.10.0 to 1.12.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v1.10.0...v1.12.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
faddat
commented
Jan 14, 2022
|
can we keep it in the upstream then just update it once merged. Ideally we close this fork when the work is done. I believe this fork was meant for permissions right @ValarDragon ? |
|
absolutely :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marko began the re-organization mentioned in #2 and this PR merges changes from his branch in cosmos-sdk/iavl with those found here.
These are mainly ease of use changes that make the iavl library more readable, BUT also adds ics23 support and a few build files and bumps tendermint itself to 0.35.0
@ValarDragon for Osmosis v7, we're planning to use 0.34.x + 0.45.0, correct?