Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: remove native staking mock #135

Merged
merged 6 commits into from
Oct 11, 2023
Merged

vault: remove native staking mock #135

merged 6 commits into from
Oct 11, 2023

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 5, 2023 •
edited by maurolacy
Loading

WIP (done). Closes part of #95.

@uint uint marked this pull request as ready for review October 10, 2023 09:12
@uint uint requested a review from maurolacy October 10, 2023 09:12
maurolacy
maurolacy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for refactoring it.

contracts/provider/vault/src/multitest.rs Outdated Show resolved Hide resolved
contracts/provider/vault/Cargo.toml Outdated Show resolved Hide resolved
contracts/provider/vault/src/multitest.rs Show resolved Hide resolved
contracts/provider/vault/src/multitest.rs Outdated Show resolved Hide resolved
@maurolacy maurolacy mentioned this pull request Oct 10, 2023
Open
10 tasks
JakeHartnell
JakeHartnell approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@maurolacy maurolacy merged commit 421905b into main Oct 11, 2023
@maurolacy maurolacy deleted the 95-remove-native-staking-mock branch October 11, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

@JakeHartnell JakeHartnell JakeHartnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uint @JakeHartnell @maurolacy