Show 0 liquidity pools in the pools page #4029
Conversation
deividaspetraitis
requested review from
MaxMillington,
JeremyParish69 and
CryptoAssassin1
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
deividaspetraitis
changed the title
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/web/components/complex/pools-table.tsxOops! Something went wrong! :( ESLint: 8.50.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/packages/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/web/components/complex/pools-table.tsx (1)
Line range hint
156-167: Consider adding visual distinction for 0 liquidity pools.To improve user experience, consider visually distinguishing pools with 0 liquidity to set proper expectations for users.
You could add a CSS class in the table row based on the liquidity value:
<tr className={classNames( "group transition-colors duration-200 ease-in-out hover:cursor-pointer hover:bg-osmoverse-850", + row.original.totalFiatValueLocked === 0 && "opacity-50", )} key={row.id} onClick={() => router.push("/pool/" + row.original.id)} >
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/web/components/complex/pools-table.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript)
- GitHub Check: Summary
- GitHub Check: wait-for-deployment
🔇 Additional comments (1)
packages/web/components/complex/pools-table.tsx (1)
156-156: LGTM! Consider monitoring performance impact.The change aligns with the PR objective to show pools with 0 liquidity. The implementation is correct and the table's virtualization will help manage the increased data load.
Since this query is marked as expensive and the change will increase the number of pools fetched, consider monitoring:
- API response times
- Client-side rendering performance
- User engagement with 0 liquidity pools
✅ Verification successful
Performance impact is already mitigated by existing optimizations
The codebase has robust performance optimizations in place:
- Dedicated edge routes for pool queries
- Table virtualization for efficient rendering
- Proper separation of expensive queries
The change to show 0 liquidity pools will be handled efficiently by these existing optimizations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any performance-related comments in the codebase rg -i "performance|expensive|heavy|slow" --type tsLength of output: 15785
There was a problem hiding this comment.
What I'm seeing in the build is that the Pools page shows pools starting at $0 liquidity (which perhaps should be required to be explicitly enabled as a toggle in settings??), and it may have inconsistent ordering.
But, also, that once clicking on one of these pools, the Pools Detail page automatically redirects to Celatone, which means the flow to add liquidity to these pools isn't shown. Clicking the browser's back Button once just goes back to Celatone (because back one time would be the pool detail page, which would just redirect you again); so you have to click Back twice to actually get back to Osmosis Zone.
What is the purpose of the change:
This PR enables including 0 liquidity pools in the pools page.
Linear Task
FE-1308
Brief Changelog
minLiquidityUsdparam from1_000to0to be sent to SQS.Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected