Improved approach to reasoning about the attacked and followed Creature #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramon-bernardo
commented
Nov 5, 2024
src/monster.cpp
Outdated
Comment on lines
648
to
657
| if (isSummon()) { | ||
| if (!canAttack(creature)) { | ||
| removeAttackedCreature(); | ||
| } | ||
| } else if (isHostile()) { | ||
| if (canAttack(creature)) { | ||
| setAttackedCreature(creature); | ||
| g_dispatcher.addTask([id = getID()]() { g_game.checkCreatureAttack(id); }); | ||
| } else { | ||
| removeAttackedCreature(); |
There was a problem hiding this comment.
This part was complex to understand. Internally, setAttackedCreature would remove the target and return a false when the current creature couldn’t attack it (e.g., due to z != z and visibility checks with canSee).
ghost
requested review from
ramon-bernardo
changed the title
ranisalt
previously approved these changes
Nov 7, 2024
…ramon-bernardo/forgottenserver into improve-attacked-creature-logic
ranisalt
approved these changes
Nov 16, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
nullptr