Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor events: Extracted into tfs::events namespace #4831

Merged
2 commits merged into from
Nov 17, 2024

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Nothing complicated here; Events has been moved to tfs::events

int32_t onSpawn = -1;
} monsterHandlers;

bool load_from_xml()

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 139 lines.
@ghost ghost requested review from ranisalt and MillhioreBT November 10, 2024 16:55
@ghost ghost merged commit d290cf5 into otland:master Nov 17, 2024
16 checks passed
@ramon-bernardo ramon-bernardo deleted the move-events-namespace branch November 17, 2024 00:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants